fix: add last login at to update password flow (#1532)#6354
Open
ludtkemorgan wants to merge 1 commit into
Open
fix: add last login at to update password flow (#1532)#6354ludtkemorgan wants to merge 1 commit into
ludtkemorgan wants to merge 1 commit into
Conversation
ludtkemorgan
added
the
1 review needed
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5218 and #5219
Description
NOTE: this has already been merged into Doorway
During last minute testing it was identified that there are users in the system that the last_login_at field is not up to date. This happens when the last time a user logged in was via the forgot password flow. In that flow we were not updating the last_login_at field.
This causes issues because that is the field we are using to determine if a user should be both deleted as well as warned of deletion. The fix is to both update that flow to start setting that field as well as updating both of those cron jobs to look at the password_updated_at field
Also, after doing checks on how many people will get deleted in the first run I realized it would be close to 13K users. So I added a LIMIT to the number. The first time it is run in production I will run it 13 times to get everyone
How Can This Be Tested/Reviewed?
Go through the whole warn user and delete user flows:
Go through the forgot password flow and make sure the last_login_at field is updated
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: