Generate monero integrated addresses #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Will check this out when I have time! Thanks @xaviablaza |
ramontayag
reviewed
Nov 14, 2018
| promises :monero_client | ||
|
|
||
| executed do |c| | ||
| RPC.config.host = ENV["XMR_HOST"] |
There was a problem hiding this comment.
Is there a way to set this up that doesn't change the global value of RPC.config? I hope to find a thread-safe version.
There was a problem hiding this comment.
I'll take a look at how Ethereum:HttpClient does its RPC calls and perhaps adapt its structure to the gem responsible for the monero RPC calls. Thank you for reviewing, I appreciate it!
xaviablaza
force-pushed
the
monero
branch
2 times, most recently
from
619131e to
6baac95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any suggestions would be greatly appreciated.
Also spent a few bucks building infrastructure like:
Any donations are also highly appreciated and will be used to investigate better infrastructure to test this feature: