Latest feedback updates #61
Open
iXavi13 wants to merge 2 commits into
Open
Conversation
gabrielleclav
suggested changes
Apr 14, 2025
| """Get the featured news article from the datastore.""" | ||
| # 1. Get all the articles | ||
| # 2. Return as a list of articles sorted by most recent date | ||
| # 1. Get all the articles and sort by most recent |
Contributor
There was a problem hiding this comment.
Is this by not most recent date? If it still is, its useful to leave that comment there.
|
|
||
|
|
||
| def get_featured_news() -> Article | None: | ||
| def get_featured_article() -> Article | None: |
Contributor
There was a problem hiding this comment.
Since we are changing the name of this function, we need to update the solutions also to resemble these changes and whatever else was changed.
| * **Hint 2:** In order to get the articles, look at how the data is written into Redis in `backend/app/__init__.py`. | ||
| * **Hint 3**: You can test the backend / API changes without the frontend code! Run `localhost:8000/{endpoint}`. | ||
| - **Hint 4:** The relevant resources can be found from [resources](./resources/overview.md). | ||
| - **Hint 5:** You will have to parse a datetime returned from Redis. Heres a useful [resource](https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformat). |
Contributor
There was a problem hiding this comment.
Another useful hint or can be placed elsewhere:
Students need to bring down the backend containers whenever they make changes and rerun it in order to see their new changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest updates based on feedback from Marvin and I
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.