Fixes for code coverage tests #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two bugs that were preventing proper code coverage test builds. The changes focus on improving test coverage accuracy and updating dependency specifications.
- Refactored logging callback logic to ensure all code paths are executed during coverage testing
- Updated tox dependency specification to use latest version instead of pinned version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/blazingmq/_ext.pyx | Modified logging callback to remove early return, ensuring coverage of logging logic |
| requirements-dev.txt | Updated tox dependency from pinned version 3.7.0 to latest available version |
Since Cython 3.1.0, Cython's tracing support leaks references to frames in at least some cases where functions have early returns. This only affects us when built with `-DCYTHON_TRACE=1`, which we only do when building for coverage analysis. There's one test that fails because of this, and we can work aronud the problem by removing the early return. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/coverage
branch
from
38932ec to
6e27a16
Compare
This pin is now standing in the way of having CI install a recent version of `pytest`, and erecnt version of `pytest-cov` are broken with the old version of `pytest`. Co-authored-by: Patrick M. Niedzielski <[email protected]> Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/coverage
branch
from
6e27a16 to
ed1563a
Compare
hallfox
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs that prevent us from correctly building a coverage test with this project.