Skip to content

Do not check for isListening when negotiationComplete #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not check for isListening when negotiationComplete #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/groups/mqb/mqbnet/mqbnet_tcpsessionfactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,13 +585,11 @@ void TCPSessionFactory::negotiationComplete(
bdlf::PlaceHolders::_3, // blob
info.get()));

if (!result || !d_isListening) {
// TODO: Revisit if still needed, following move to mwcio.
//
// If 'stopListening' have been called, 'tearDown' may or may not
// have been called, depending whether the 'callback' has been
// called before or after 'stopListening'. Invoke 'tearDown'
// explicitly (it supports subsequent calls).
if (!result) {
// If 'stopListening' have been called, 'tearDown' may or may not have
// been called, depending whether the 'callback' has been called before
// or after 'stopListening'. Invoke 'tearDown' explicitly (it supports
// subsequent calls).

BALL_LOG_WARN << "#TCP_UNEXPECTED_STATE "
<< "TCPSessionFactory '" << d_config.name()
Expand Down