CI: Add CI checks with clang-tidy #454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
force-pushed
the
syntax-checks
branch
2 times, most recently
from
db3f89a to
ac60326
Compare
hallfox
changed the title
hallfox
force-pushed
the
syntax-checks
branch
4 times, most recently
from
8d0fcce to
1020655
Compare
Signed-off-by: Taylor Foxhall <[email protected]>
| "inherits": "base" | ||
| }, | ||
| { |
There was a problem hiding this comment.
This is a good change even beyond clang-tidy. Simplifies CI a lot.
There was a problem hiding this comment.
Coming back to this and in reference to our (@hallfox, @emelialei88) offline discussion earlier today, it may be best to pull this out into its own PR (plus other useful presets).
I'll take a stab at this tomorrow and send it your way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new check to our workflows using clang-tidy. Right now we only enable analyzer checks, though we could look at expanding to more in the future. We are primarily interested in getting another pass over our code checking for C++03 syntax compatibility, since we've had a few instances of modern syntax constructs getting into the code base.
clang-tidywill do a bit more than syntax checks, but I believe having will be a boon overall.