-
Notifications
You must be signed in to change notification settings - Fork 141
feat getting rid of queue creation/deletion cbs #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dorjesinpo
commented
Feb 5, 2025
- removing queue creation/deletion cbs
- a step towards converging CSL/legacy
de336eb
to
c377025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost made a big blunder, Vitaly :)
removeRecordRaw(recHandles[idx]); | ||
} | ||
} | ||
// In ANY mode, any outstanding QueueOp records are deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove the isCSL
checks at
blazingmq/src/groups/mqb/mqbc/mqbc_storageutil.cpp
Lines 3005 to 3045 in c377025
if (isCSLMode) { | |
const bsls::Types::Int64 numMsgs = rs->numMessages( | |
mqbu::StorageKey::k_NULL_KEY); | |
if (0 != numMsgs) { | |
BMQTSK_ALARMLOG_ALARM("REPLICATION") | |
<< clusterDescription << " Partition [" << partitionId | |
<< "]: Attempt to delete storage for queue [ " << uri | |
<< "], queueKey [" << queueKey << "] which has [" | |
<< numMsgs << "] outstanding messages." | |
<< BMQTSK_ALARMLOG_END; | |
if (status) { | |
*status = rc_QUEUE_HAS_MESSAGES; | |
} | |
return; // RETURN | |
} | |
const mqbs::ReplicatedStorage::RecordHandles& recHandles = | |
rs->queueOpRecordHandles(); | |
for (size_t idx = 0; idx < recHandles.size(); ++idx) { | |
fs->removeRecordRaw(recHandles[idx]); | |
} | |
} | |
BALL_LOG_INFO << clusterDescription << ": Partition [" << partitionId | |
<< "], Deleting storage for queue [" << uri | |
<< "], queueKey [" << queueKey << "] as replica."; | |
fs->unregisterStorage(rs); | |
storageMap->erase(it); | |
if (status) { | |
*status = rc_SUCCESS; | |
} | |
return; // RETURN | |
} | |
// A specific appId is being deleted. | |
if (isCSLMode) { | |
rs->purge(appKey); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2463 of commit c377025 has completed with FAILURE
c377025
to
e149656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2505 of commit e149656 has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6f1e8b4
to
61d0282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2625 of commit 61d0282 has completed with FAILURE
61d0282
to
683876c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2653 of commit 683876c has completed with FAILURE
533e9a1
to
df37dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 2790 of commit df37dc6 has completed with FAILURE
Signed-off-by: dorjesinpo <[email protected]>
Signed-off-by: dorjesinpo <[email protected]>
df37dc6
to
793bcf1
Compare