Fix mqbstat_queuestats.cpp: Publish per app id metrics from proxies too #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikulimu
changed the title
kaikulimu
force-pushed
the
proxy-app-metric
branch
from
8ae77ca to
6eda421
Compare
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
pniedzielski
force-pushed
the
proxy-app-metric
branch
from
6eda421 to
30c2bfa
Compare
|
After discussion with team, we decided not to support publishing app id metrics from proxies. |
|
Notably, proxies don't have the full domain configuration (i.e. list of appIds) so they don't create stat subcontexts for each appId. Reconfiguring on the cluster also don't propagate appId information to proxies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we report confirmation time only between the last hop and the consumer, we need to report app id metric from proxies in case they are the last hop.