Feat FSM mode: Still write to QList file #661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
2 times, most recently
from
1af2464 to
4e9dbfc
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
9ac9f23 to
c7290fd
Compare
kaikulimu
changed the title
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
2 times, most recently
from
be8a299 to
0853597
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
3 times, most recently
from
946ac16 to
339a417
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
339a417 to
c8234b1
Compare
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
c8234b1 to
2814c97
Compare
dorjesinpo
requested changes
Apr 9, 2025
| @@ -246,6 +246,10 @@ class RecoveryManager { | |||
| /// Allocator to use | |||
| bslma::Allocator* d_allocator_p; | |||
|
|
|||
| bool d_qListAware; | |||
| // Whether the broker still read and writes to the to-be-deprecated Qlist | |||
| if (needQList) { | ||
| recoveryFileSet.setQlistFileSize(d_config.maxQlistFileSize()); | ||
| } | ||
| recoveryFileSet.setQlistFileSize(d_qListAware ? d_config.maxQlistFileSize() |
There was a problem hiding this comment.
why not if (d_qListAware) { ?
| if (needQList) { | ||
| fileSetSp->d_qlistFilePosition = qlistFileOffset; | ||
| } | ||
| fileSetSp->d_qlistFilePosition = d_qListAware ? qlistFileOffset : 0; |
There was a problem hiding this comment.
why not if (d_qListAware) { ? (and below)
| << BMQTSK_ALARMLOG_END; | ||
| return rc_QUEUE_URI_MISMATCH; // RETURN | ||
| if (d_isFSMWorkflow) { | ||
| if (qinfo.canonicalQueueUri() != uri) { |
There was a problem hiding this comment.
If d_isFSMWorkflow is false, would qinfo.canonicalQueueUri() ever be not empty?
| << ", index: " << jit->recordIndex() | ||
| << ", with appId/appKey mismatch. " | ||
| "Expected appId/appKey [" | ||
| << qinfoAppCit->second << ", " |
There was a problem hiding this comment.
If qinfoAppCit == qinfo.appIdKeyPairs().cend(), dereferencing qinfoAppCit would not work.
| @@ -3880,6 +3914,10 @@ int FileStore::issueSyncPointInternal(SyncPointType::Enum type, | |||
| 2 * FileStoreProtocol::k_JOURNAL_RECORD_SIZE)); | |||
| } | |||
|
|
|||
| BALL_LOG_ERROR << "Henshin! d_primaryLeaseId: " << d_primaryLeaseId | |||
| @@ -5022,7 +5058,8 @@ void FileStore::replicateRecord(bmqp::StorageMessageType::Enum type, | |||
| FileStoreProtocol::k_JOURNAL_RECORD_SIZE); | |||
|
|
|||
| bdlbb::BlobBuffer dataBlobBuffer; | |||
| if (!d_isFSMWorkflow || bmqp::StorageMessageType::e_DATA == type) { | |||
| if (bmqp::StorageMessageType::e_DATA == type || | |||
There was a problem hiding this comment.
what about else? Any asserts?
| bmqp::Protocol::k_WORD_SIZE | ||
| : 0; | ||
|
|
||
| BALL_LOG_ERROR << "Henshin Baron! " << d_qListAware << ", " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing code, FSM mode never writes to QList file. In this PR, we add a new
doesFSMWriteQLISTflag to determine whether FSM mode still writes to QList file. Note that the PartitionFSMs do not synchronize QList file; they only synchronize journal and data files. Such synchronization will be added in a subsequent PR.A benefit of this PR is that we are finally able to test switching from non-FSM to FSM then back to non-FSM in
test_restart.py.Also note that this PR is low-risk since it only affects FSM mode.