Feat FSM mode: Still write to QList file #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
2 times, most recently
from
1af2464 to
4e9dbfc
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
9ac9f23 to
c7290fd
Compare
kaikulimu
changed the title
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
2 times, most recently
from
be8a299 to
0853597
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
3 times, most recently
from
946ac16 to
339a417
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
2 times, most recently
from
c8234b1 to
2814c97
Compare
dorjesinpo
requested changes
Apr 9, 2025
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
11 times, most recently
from
a130856 to
1a876e7
Compare
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
6345586 to
a813713
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
3eeba18 to
a63eca7
Compare
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
kaikulimu
force-pushed
the
fsm-test--fsm-write-qlist
branch
from
a63eca7 to
600e57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing code, FSM mode never writes to QList file. In this PR, we add a new
doesFSMWriteQLISTflag to determine whether FSM mode still writes to QList file. Note that in existing code the PartitionFSMs do not synchronize QList file; they only synchronize journal and data files; this PR adds sync for QList file.A benefit of this PR is that we are finally able to test switching from non-FSM to FSM then back to non-FSM in
test_restart.py.Also note that this PR is low-risk since it only affects FSM mode.