Fix: Support setting thread names on more platforms than Linux #702
+38
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
fix/bdlmt-thread-names
branch
from
b307c85 to
85e05b5
Compare
This patch replaces the manual implementation of `bmqsys::ThreadUtil::setCurrentThreadName` with an implementation using BDE, which supports more platforms. For the moment, we keep `bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME` only being true on Linux, as there appear to be other places this constant is used. Signed-off-by: Patrick M. Niedzielski <[email protected]>
The contracts of `bmqsys::ThreadUtil::setCurrentThreadName` and `bmqsys::ThreadUtil::setCurrentThreadNameOnce` are wide; they may be called on any platform, and they have no side effects on platforms where setting a thread name is unsupported. This means we do not need to guard calls to them by checking a constant that is only true on platforms where setting a thread name is supported. This patch removes all such guards, which removes all uses of this constant. In most cases, the use of this constant is in an `if` statement that obviously wraps some call to `bmqsys::ThreadUtil::setCurrentThreadName` or `bmqsys::ThreadUtil::setCurrentThreadNameOnce`. The only less obvious case is in `m_bmqbrkr_task`’s mtrap support, where this constant guards a write of the command `k_MTRAP_SET_THREADNAME` to the mtrap pipe. The command is handled by `Task::onControlMessage` in the same file, which in turn calls `bmqsys::ThreadUtil::setCurrentThreadName`. Presumably, this is where the `if` guard should have been, but now it is safe to remove the guard on the write. Signed-off-by: Patrick M. Niedzielski <[email protected]>
With the previous commit, this constant is no longer used in BlazingMQ. Because it is not part of our public interface, it is safe to remove this constant. This patch removes it. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/bdlmt-thread-names
branch
from
85e05b5 to
21f316d
Compare
chrisbeard
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches allows us to set thread names on all platforms that BDE's
bslmt::ThreadUtilsupports, which currently is Linux, Solaris, Darwin, and Windows.