Do not expose internal error codes to client #5010
Draft
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgando
changed the title
Signed-off-by: Morgan Douglas <[email protected]> Extend Signed-off-by: Morgan Douglas <[email protected]> Add func/line Signed-off-by: Morgan Douglas <[email protected]>
morgando
commented
Feb 11, 2025
| errstat_cat_strf(&iq->errstat, | ||
| " unable to update record rc = %d", rc); | ||
| errstat_cat_strf(&iq->errstat," unable to update record"); | ||
| logmsg(LOGMSG_ERROR, "%s:%d Failed to update record. Internal error code is %d\n", |
There was a problem hiding this comment.
We might need this for diagnosing an issue if we send 'generic internal error' to the client
roborivers
suggested changes
Feb 11, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/597 tests failed ⚠.
The first 10 failing tests are:
fdb_compat
sc_timepart_multiddl_generated
yast
yast_stat4scan_generated
op_makerecord
upsert
ddl_no_csc2
max_wr_rows_partial_index_off_generated
max_wr_rows
incremental_backup_load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove internal error codes hardcoded into client error messages.