Skip to content

Hold table locks when needed during analyze #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

morgando
Copy link
Contributor

@morgando morgando commented Mar 7, 2025

The changes in this PR guard dbtable access with a table lock

@morgando morgando requested a review from aakash10292 March 7, 2025 21:52
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/569 tests failed ⚠.

The first 10 failing tests are:
sc_truncate
phys_rep_perf
sc_timepart
sc_timepart_logicalsc_generated
analyze_partial_index_off_generated
analyze
incremental_backup_load
truncatesc_offline_generated

@morgando morgando marked this pull request as draft March 10, 2025 14:09
@morgando morgando force-pushed the test_analyze_during_drop branch from e08bc34 to 9bb6316 Compare March 10, 2025 14:14
@morgando morgando marked this pull request as ready for review March 10, 2025 14:14
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 364/569 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
sc_timepart
yast
yast_stat4scan_generated
analyze_recover_deadlock
analyze_partial_index_off_generated
analyze
autoanalyze
temp_table_truncate_leak
sc_resume2

@morgando morgando force-pushed the test_analyze_during_drop branch from 3320810 to 1e9a0ee Compare March 10, 2025 21:47
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 4/569 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
sc_timepart_logicalsc_generated
incremental_backup_load
truncatesc_offline_generated

@morgando morgando force-pushed the test_analyze_during_drop branch 3 times, most recently from 5fc9635 to 45909ef Compare March 11, 2025 18:52
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/569 tests failed ⚠.

The first 10 failing tests are:
sc_truncate
sc_transactional_rowlocks_generated
phys_rep_perf
sc_timepart
rem
incremental_backup_load
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 4/569 tests failed ⚠.

The first 10 failing tests are:
logfill_logput_window_generated
phys_rep_perf
incremental_backup_load
truncatesc_offline_generated

@morgando morgando force-pushed the test_analyze_during_drop branch 4 times, most recently from 3016acf to 7106d75 Compare March 12, 2025 15:29
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/569 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
sc_timepart_logicalsc_generated
analyze_partial_index_off_generated
analyze
incremental_backup_load
truncatesc_offline_generated

Signed-off-by: Morgan Douglas <[email protected]>

Update test

Signed-off-by: mdouglas47 <[email protected]>

Add to impl

Signed-off-by: mdouglas47 <[email protected]>

Update

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Change name of tunable

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Revert

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Add expected output for test

Signed-off-by: mdouglas47 <[email protected]>

Use curtran

Signed-off-by: mdouglas47 <[email protected]>

Only use curtran if possible

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

Consistent naming

Signed-off-by: mdouglas47 <[email protected]>

Use existing function

Signed-off-by: mdouglas47 <[email protected]>

Tweak

Signed-off-by: mdouglas47 <[email protected]>

source file

Signed-off-by: mdouglas47 <[email protected]>
@morgando morgando force-pushed the test_analyze_during_drop branch from 7106d75 to fde1743 Compare April 7, 2025 18:00
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/569 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
sc_timepart
sc_timepart_logicalsc_generated
nightmare_recovery
incremental_backup_load
truncatesc_offline_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants