Skip to content

Block resuming a partition merge schema change #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorinhogea
Copy link
Contributor

@dorinhogea dorinhogea commented Mar 17, 2025

The actual fix to survive master swings requires more time at this point, so lets block resume for now (matching 8.0) behavior.

The 8.0 patch was merged here:
#4936

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/602 tests failed ⚠.

The first 10 failing tests are:
timepart_readonly
sc_transactional_rowlocks_generated
sc_repeated_updates_logicalsc_generated
triggersc_latency

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/604 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
timepart_readonly
reco-ddlk-sql
sc_resume_partition

…e sharing the destination newdb,

which involves more complicated code changes and it will be properly addressed in a future PR.

Signed-off-by: Dorin Hogea <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/605 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_resume_partition
incoherent_sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants