Generic sharding : organize llmeta and create views #5079
+786
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakash10292
force-pushed
the
aar_sharding_views
branch
2 times, most recently
from
24f031f to
2d04d4c
Compare
roborivers
suggested changes
Mar 19, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 5/602 tests failed ⚠.
The first 10 failing tests are:
sc_transactional_rowlocks_generated
analyze_partial_index_off_generated
analyze
remotecreate
tunables
roborivers
suggested changes
Mar 20, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 6/602 tests failed ⚠.
The first 10 failing tests are:
sc_transactional_rowlocks_generated
queuedb_rollover
analyze_partial_index_off_generated
analyze
tunables
remotecreate
aakash10292
force-pushed
the
aar_sharding_views
branch
3 times, most recently
from
7aab3a1 to
35c4b46
Compare
Signed-off-by: Aakash Arayambeth <[email protected]>
aakash10292
force-pushed
the
aar_sharding_views
branch
from
35c4b46 to
d46fad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5055
With this change, selects against generic sharded tables should work , without any pruning.
TEST PENDING