moar comdb2_tunables #5114
Open
moar comdb2_tunables #5114
+67
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshatsikarwar
commented
Apr 10, 2025
•
akshatsikarwar
commented
- PUT TUNABLE does not have to be a write-transaction
- Make some tunables mutable
- Remove obsolete tunables
- Add more tunables
Signed-off-by: Akshat Sikarwar <[email protected]>
roborivers
suggested changes
Apr 10, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 2/604 tests failed ⚠.
The first 10 failing tests are:
incoherent_sql
cldeadlock
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
roborivers
suggested changes
Apr 11, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/604 tests failed ⚠.
The first 10 failing tests are:
timepart_readonly
tunables
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
roborivers
suggested changes
Apr 11, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/605 tests failed ⚠.
The first 10 failing tests are:
timepart_readonly
incoherent_sql
cldeadlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.