Require protobuf schema change serialization #5636
Open
+39
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Douglas <[email protected]>
morgando
force-pushed
the
only-sc-protobuf
branch
from
189b424 to
07a3f9b
Compare
morgando
changed the title
roborivers
approved these changes
Dec 18, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
insert_lots
reco-ddlk-sql
morgando
commented
Dec 18, 2025
| free(buf); | ||
| return NULL; | ||
| } | ||
| p_buf = p_buf_end = buf + plen; |
Contributor
Author
There was a problem hiding this comment.
I got rid of this line because if we return zero from pack_schema_change_protobuf, then buf is guaranteed to be non-null. if buf is non null, then p_buf won't be null. If p_buf is never null, then we don't need to compute p_buf and can get rid of the if (!p_buf) block below.
Contributor
Author
There was a problem hiding this comment.
also removed p_buf_end because it is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes non-protobuf schema change serialization code.
Don't merge until we're sure we won't want to do a direct 8.0 -> 8.2 upgrade (8.0 doesn't understand the protobuf format, so we would need to have it disabled during the upgrade process so that the nodes coming up as 8.2 don't send messages that the 8.0 nodes don't understand)