Add a timeout to the socket in memray attach
#753
+15
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: N/A
Describe your changes
Adds a timeout to
memray attach
to prevent some rare hangs if the attached Python process crashed or begins finalizing.Testing performed
Removed this line to simulate the process never attaching.
Additional context
I arbitrarily chose 10 seconds as the timeout. It's probably fine to shorten that, but I don't know how long it usually takes for Memray to connect on slower systems.
cc @godlygeek