Update test_exercise_3.py #754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloomberg#743 testing in Python version 3.13, the solution uses a bit more memory than previously in Python version 3.12. I saw an increase up to about 170MB of memory used for my run. The provided example which is meant to use too much memory uses about 740MB. So I think a new threshold of 200MB should be sufficient. This will also be backwards compatible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 92.90% 92.87% -0.04%
==========================================
Files 95 95
Lines 11687 11687
Branches 407 407
==========================================
- Hits 10858 10854 -4
- Misses 829 833 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#743 testing in Python version 3.13, the solution uses a bit more memory than previously in Python version 3.12.
I saw an increase up to about 170MB of memory used for my run.
The provided example which is meant to use too much memory uses about 740MB.
So I think a new threshold of 200MB should be sufficient. This will also be backwards compatible.