Skip to content

Conversation

@mattrm456
Copy link
Contributor

This PR removes an erroneous assertion:

BSLS_ASSERT((!error && context.bytesSent() > 0) || (error == ntsa::Error::e_WOULD_BLOCK));

in ntcr::StreamSocket::privateSendRaw() in the code path taken when trying to send and ntsa::Data. This assertion cannot be true if the send buffer is already full and we must enqueue the entirety of the ntsa::Data onto the write queue. This assertion appears to have been left-over from a prior implementation iteration and not cleaned up when the implementation evolved. This assertion does not appear in the more-commonly taken code path when the user is trying to send a bdlbb::Blob.

@mattrm456 mattrm456 merged commit 7fc7960 into bloomberg:main Nov 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant