RDISCROWD-7728 ownership id on project create page #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14199405470Details
💛 - Coveralls |
dchhabda
reviewed
Mar 24, 2025
pybossa/api/project.py
Outdated
| validate_ownership_id(project.info.get('ownership_id')) | ||
| if not valid_ownership_id(project.info.get('ownership_id')): | ||
| ownership_id_title = current_app.config.get('OWNERSHIP_ID_TITLE', 'Ownership ID') | ||
| raise ValueError(f"{ownership_id_title} must be numeric and less than 20 characters.") |
There was a problem hiding this comment.
Seems inconsistent behavior with the error is getting reported via api above and from fronted here as the error messages are different; line above missing Got :<input-number>. It would be nice to have a single place from where a consistent error message is reported back both for api or frontend. This can be achieved via existing similar implementations here
pybossa/util.py
Outdated
Comment on lines
376
to
381
| def valid_ownership_id(o_id): | ||
| if o_id == None or len(o_id) == 0: | ||
| return | ||
| return True | ||
| if not (o_id.isnumeric() and len(o_id) <= 20): | ||
| raise ValueError(f"{ownership_id_title} must be numeric and less than 20 characters. Got: {o_id}") | ||
| return False | ||
| return True |
There was a problem hiding this comment.
- Is it possible to pass numeric value to this function thereby causing
isnumericcall to raise exception - Can this function be refactored so that it returns True only when condition is satisfied and False otherwise
ex
if not o_id or (isinstance(o_id, str) and o_id.isnumeric() and len(o_id) <= 20):
return True
return False
n00rsy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: RDISCROWD-7728
Describe your changes
Related
bloomberg/pybossa-default-theme#488