-
Notifications
You must be signed in to change notification settings - Fork 11
feat: fish autocomplete #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@molisani Love the package! Let me know if you have any suggestions |
Ah, thank you very much for this contribution! This looks like all the machinery needed to register an autocomplete command with However, I'm not familiar with how I don't think we would necessarily need that to get this PR merged, as the logic you've written up here is still correct and necessary, but I would want to make sure that we have a through-line for confirming that auto-complete works as expected. |
Signed-off-by: loks0n <[email protected]>
Signed-off-by: loks0n <[email protected]>
Signed-off-by: loks0n <[email protected]>
Signed-off-by: loks0n <[email protected]>
Ah right! I think it's slightly different. I've gone ahead and created a new file specifically for fish. Let me know if you want to go with an alternative approach. |
I've created #58 which changes the approach for handling different shells. It needs further review from my team and there may be some small changes before it gets merged, but I think it would be easier to land your changes on top of #58. I'm currently out-of-office this week but I think once I am back I can prioritize that PR to make way for your feature. |
Adds auto completion for fish shell