Optimize server browser#205
Draft
robalni wants to merge 8 commits intoblue-nebula:masterfrom
robalni:optimize-server-browser
Draft
Optimize server browser#205robalni wants to merge 8 commits intoblue-nebula:masterfrom robalni:optimize-server-browser
robalni wants to merge 8 commits intoblue-nebula:masterfrom
robalni:optimize-server-browser
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes currently reduce the frame time of the server browser menu from 9.6 to 5.6 milliseconds on my computer.
The changes include two things: Simplified cubescript code and a new feature: {} blocks. The {} blocks are compiled directly in the compile phase and not treated as strings, that would be compiled on each frame when the code runs.
This is a work in progress and I don't know if this is the best solution. What do you think about it?