Skip to content

Comments

Update appstream, .desktop file and add appstream install step in cmakelists#274

Merged
voidanix merged 3 commits intoblue-nebula:masterfrom
user1-github:master
Dec 7, 2025
Merged

Update appstream, .desktop file and add appstream install step in cmakelists#274
voidanix merged 3 commits intoblue-nebula:masterfrom
user1-github:master

Conversation

@user1-github
Copy link
Contributor

@user1-github user1-github commented Dec 5, 2025

As promised, this is the main PR with the updates / improvements I was talking about.
Note: before merging it, this PR in the misc repo should be merged, so that I can change to the proper screenshot urls in the appstream file.

Before releasing a new version, the new version number should be added to the releases section of the appstream file.

Btw, I've also added brand colors to the appstream file. It's not a hard requirement, but an optional aesthetic touch to make an app look nice on various Linux store frontends. Here is how they look like:

Blue_Nebula_brand_colors

@voidanix Regarding the Flatpak, based on my changes above, I've already built a working test build of Blue Nebula Flatpak and it works well! (ignore the Red Eclipse Legacy id, as I cannot change it in PRs of existing apps).
Also, here is how the Flatpak manifest currently looks like. It turned out to be much simpler than I thought it would be thanks to the well made cmake system install steps.

So now I guess the only thing left is making the first official release after which we can publish it on Flathub :)

Though I still wonder if we should rebase the Red Eclipse Legacy Flatpak to Blue Nebula Flatpak.
Because at this point Blue Nebula is basically an improved RE 1.6.0, so I don't really see how would it disappoint some users. Afaik, the eol rebase doesn't force users to switch to the new Flatpak (it first asks them) and if they agree, then there's also some mechanism to migrate user data from the old Flatpak to the new one.
Or is there something 1.6.0 used to have that Blue Nebula has removed?

@user1-github
Copy link
Contributor Author

user1-github commented Dec 7, 2025

Done. Slightly unrelated to this PR, but:

  • I need to choose an app id before I submit the Flatpak. Is the following id ok for you? org.blue_nebula.Blue-Nebula Note: Using dashes is not allowed in the app id middle section, so I had to replace it with an underscore (it's a common practice for Flatpak apps whose websites use dashes).

  • In the Flatpak manifest I had to set -DCMAKE_POLICY_VERSION_MINIMUM=3.5 because Flatpak builder doesn't accept anything older. Should we update the minimum cmake version in the main CMakeLists.txt, or is there a good reason to stay with current version 3.0?

  • I also think it's a good idea to update enet to the latest version for potential bugfixes. Though I can't deal with git submodules atm, so I won't be able to update it myself.

@voidanix
Copy link
Member

voidanix commented Dec 7, 2025

Is the following id ok for you? org.blue_nebula.Blue-Nebula

I would personally prefer org.blue_nebula.BlueNebula then. FWIW I believe you should also update the developer id with the underscore to make things consistent.

In the Flatpak manifest I had to set -DCMAKE_POLICY_VERSION_MINIMUM=3.5 because Flatpak builder doesn't accept anything older.

@TheAssassin just bumped the minimum version to 3.5 in 9478d4c, so you can safely remove that from the manifest.

I also think it's a good idea to update enet to the latest version for potential bugfixes

Also done, see 9bc9fba

The changes are based on the current upstream Red Eclipse .desktop file.
@user1-github
Copy link
Contributor Author

user1-github commented Dec 7, 2025

FWIW I believe you should also update the developer id with the underscore to make things consistent.

I also thought about it, but from what I've seen in other apps, I think the developer id should be left as is. For example, Dosbox X Flatpak has an underscore in its app id, but not in the developer id. I just don't know if changing to an underscore in developer id will cause issues.

@voidanix
Copy link
Member

voidanix commented Dec 7, 2025

For example, Dosbox X Flatpak has an underscore in its app id, but not in the developer id.

Good to know. Fine by me then :)

Copy link
Member

@voidanix voidanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Add brand colors to appstream
* Use non-deprecated developer tag and update screenshot urls
@voidanix voidanix force-pushed the master branch 2 times, most recently from 4e896e8 to 794eef7 Compare December 7, 2025 14:45
@voidanix voidanix merged commit 61cc32d into blue-nebula:master Dec 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants