Update appstream, .desktop file and add appstream install step in cmakelists#274
Update appstream, .desktop file and add appstream install step in cmakelists#274voidanix merged 3 commits intoblue-nebula:masterfrom
Conversation
|
Done. Slightly unrelated to this PR, but:
|
I would personally prefer
@TheAssassin just bumped the minimum version to 3.5 in 9478d4c, so you can safely remove that from the manifest.
Also done, see 9bc9fba |
The changes are based on the current upstream Red Eclipse .desktop file.
I also thought about it, but from what I've seen in other apps, I think the developer id should be left as is. For example, Dosbox X Flatpak has an underscore in its app id, but not in the developer id. I just don't know if changing to an underscore in developer id will cause issues. |
Good to know. Fine by me then :) |
* Add brand colors to appstream * Use non-deprecated developer tag and update screenshot urls
4e896e8 to
794eef7
Compare
As promised, this is the main PR with the updates / improvements I was talking about.
Note: before merging it, this PR in the misc repo should be merged, so that I can change to the proper screenshot urls in the appstream file.
Before releasing a new version, the new version number should be added to the releases section of the appstream file.
Btw, I've also added brand colors to the appstream file. It's not a hard requirement, but an optional aesthetic touch to make an app look nice on various Linux store frontends. Here is how they look like:
@voidanix Regarding the Flatpak, based on my changes above, I've already built a working test build of Blue Nebula Flatpak and it works well! (ignore the Red Eclipse Legacy id, as I cannot change it in PRs of existing apps).
Also, here is how the Flatpak manifest currently looks like. It turned out to be much simpler than I thought it would be thanks to the well made cmake system install steps.
So now I guess the only thing left is making the first official release after which we can publish it on Flathub :)
Though I still wonder if we should rebase the Red Eclipse Legacy Flatpak to Blue Nebula Flatpak.
Because at this point Blue Nebula is basically an improved RE 1.6.0, so I don't really see how would it disappoint some users. Afaik, the eol rebase doesn't force users to switch to the new Flatpak (it first asks them) and if they agree, then there's also some mechanism to migrate user data from the old Flatpak to the new one.
Or is there something 1.6.0 used to have that Blue Nebula has removed?