fix(inspector): ignore stale SELFDESTRUCT journal entries#3805
Open
0xalpharush wants to merge 1 commit into
Open
fix(inspector): ignore stale SELFDESTRUCT journal entries#38050xalpharush wants to merge 1 commit into
0xalpharush wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
0xalpharush
force-pushed
the
agent/selfdestruct-inspector-journal-main
branch
from
July 17, 2026 14:14
aafdfd5 to
dee35be
Compare
0xalpharush
marked this pull request as ready for review
July 17, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reapplies the standalone fix from #3797 directly onto
main, per the maintainer feedback in that PR.Root cause
Under EIP-6780, SELFDESTRUCT-to-self can be a state no-op and append no destruction entry. The inspector previously read
journal.last(), which could reuse an unrelated earlier balance transfer or destruction and emit a false SELFDESTRUCT callback with stale metadata.Execution, state, and receipts are unaffected; this corrects inspector/tracer callbacks.
Validation
cargo test -p revm-inspector cancun_selfdestruct_to_self_does_not_reuse_prior_journal_entrycargo test -p revm-inspector --libcargo check -p revm-inspector --all-featurescargo check -p revm-inspector --no-default-featurescargo clippy -p revm-inspector --all-targets --all-features -- -D warningscargo fmt --all --check