[Fix] Fixed app startup crash when Media Feature Pack is not installed

[krll-kov]

Fixed #1956 this issue related to missing MFP on N and KN versions of Windows (European and Korean)

Now plugin uses delayed load mechanism for important dlls and adds error messages to log when trying to set source when this issue is present.

There are no breaking changes in this update

[Gustl22]

Thank you for contributing. And sorry, always struggling to find time for review.

I wonder if we could just try catch all errors to avoid crashes like done in our linux implementation:

audioplayers/packages/audioplayers_linux/linux/audioplayers_linux_plugin.cc

Line 139 in 71f6a2d

try {

That way all other methods don't need a special handling and the error is propagated to the user.

If want to warn exactly about this specific issue (which is not player or source related -> so global) one could introduce a check on the global channel level on first initialization and throw an error if Media Feature Pack is not installed.

I will have a closer look once our pipeline is working again properly ;D

[krll-kov]

Thank you for contributing. And sorry, always struggling to find time for review.

I wonder if we could just try catch all errors to avoid crashes like done in our linux implementation:

audioplayers/packages/audioplayers_linux/linux/audioplayers_linux_plugin.cc

Line 139 in 71f6a2d

try {

That way all other methods don't need a special handling and the error is propagated to the user.

If want to warn exactly about this specific issue (which is not player or source related -> so global) one could introduce a check on the global channel level on first initialization and throw an error if Media Feature Pack is not installed.

I will have a closer look once our pipeline is working again properly ;D

No, unfortunately, try catch was not possible during tests, app just crashed. Even __try __catch with specific error did not help

[Gustl22]

Sorry for the delay, the linking in CMakeLists looks good. I just want to confirm, if there might be a better way to handle the error on startup. Unfortunately I have to wait for my new laptop, so I can test this on a Windows VM with enough space.

[13thdeus]

Any updates on this?

[krll-kov]

Any updates on this?

main...krll-kov:audioplayers:main

Just git clone the repo, add these changes and add dependency as override, using this fix for year, everything works fine

permission_handler_windows:
git:
url: https://github.com/your-git-name/flutter-permission-handler.git
path: permission_handler_windows
ref: main

[Gustl22]

Sorry still waiting for my laptop...feel free to git checkout as proposed!

[Gustl22]

@krll-kov, finally my laptop arrived and I had time to test on a "Windows N" system.
While debugging, I noticed some imrovements one could make to handle the case more generally, so I created #2019.
The main differences are:

• We do not work on a per player level, but on the platform level
• An error is thrown, when a method is called. I don't see a benefit in handle player calls gracefully, as some of them are waiting for an event from the platform, which will never occur, and then throw a timeout. So better to have the clear reason directly in the answer.
• The implementation in this PR crashed the example app as soon as platform calls were made (which should be avoided I guess).
• Version and Changelog are auto-generated on release, so no need to add it in the PRs.

I value your initiation and will add you as co-author!

[Gustl22]

Closing as continued in #2019