Skip to content

[chore]: Improved metrics_core test and remove duplicate patterns #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yelodevopsi
Copy link
Contributor

@yelodevopsi yelodevopsi commented Mar 20, 2025

  • Bugfix: removed duplicate paths_* and hls_muxers_* patterns
  • Rewrite regexp to pattern array instead:
    ** This gives specific error to which line fails in test32 and test64.
  • The old code just tells "something" in the regexp is wrong, but not which

* Rewrite to pattern array: This gives specific error to which line fails in test32 and test64.
* The old code just tells "something" in the regexp is wrong, but not which
@yelodevopsi yelodevopsi changed the title [chore]: Bugfix: removed duplicate paths_* and hls_muxers_* patterns [chore]: Improved metrics_core test and remove duplicate patterns Mar 20, 2025
@aler9
Copy link
Member

aler9 commented Mar 24, 2025

Hello, this is nice but there are a couple of missing things:

  • the new test does not check for the presence of additional lines other than the ones defined inside patterns. For instance, if there's a extraneous metric called webrtc_should_not_be_here, the test allows it (while it shouldn't)
  • the new test does not check for the presence of repeated lines - for instance, if there are two metrics srt_conns_mbps_send_rate and srt_conns_mbps_send_rate, the test allows it (while it shouldn't)

can you upgrade the code in order to account for these missing test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants