always-available: support disabling recording when source is offline#5767
Open
AbdElrahmaN31 wants to merge 1 commit into
Open
always-available: support disabling recording when source is offline#5767AbdElrahmaN31 wants to merge 1 commit into
AbdElrahmaN31 wants to merge 1 commit into
Conversation
…luenviron#5587) Add `alwaysAvailableRecorded` parameter that controls whether recording happens during offline periods for always-available paths. When set to false, recording only starts when a real source is connected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
alwaysAvailableRecordedparameter that controls whether recording happens during offline periods for always-available paths. When set tofalse, recording only starts when a real source is connected and stops when it disconnects.Default is
true, preserving current behavior.Closes #5587
Changes
internal/conf/path.go: AddAlwaysAvailableRecordedconfig field (default:true)internal/core/path.go: Conditional recording start/stop based on the new flag insetAvailable(),doAddPublisher(),executeRemovePublisher(), anddoReloadConf()internal/conf/conf_test.go: Update test expected structdocs/2-features/08-always-available.md: Document the new parameterTesting
go test ./internal/conf/...)go build ./...)