Improve remote access support#2815
Merged
joaoantoniocardoso merged 6 commits intobluerobotics:masterfrom Sep 18, 2024
Merged
Conversation
Williangalvani
force-pushed
the
new_extension_links
branch
2 times, most recently
from
0ce272b to
0c94b1e
Compare
Williangalvani
changed the title
Williangalvani
force-pushed
the
new_extension_links
branch
3 times, most recently
from
2e74ab6 to
58ef4a2
Compare
Williangalvani
changed the title
Member
Author
|
@patrickelectric @voorloopnul can you give this a try? I have a cockpit branch at https://github.com/bluerobotics/cockpit/compare/master...Williangalvani:cockpit:remote_access?expand=1 with the changes and a stun server. it is deployed at williangalvani/cockpit:remote2 |
Williangalvani
force-pushed
the
new_extension_links
branch
from
58ef4a2 to
5600e0a
Compare
Member
Author
|
rebased |
Member
patrickelectric
left a comment
patrickelectric
left a comment
There was a problem hiding this comment.
I forgot to submit it 🤦
| logging.info(f"file '{filename}' not found ({e}):, a new one will be created") | ||
| with open(filename, "w", encoding="utf-8") as f: | ||
| logging.info(f"updating nginx route for {name}") | ||
| f.write(text) |
Member
There was a problem hiding this comment.
If the context is different we need to erase it and then writing to it no ?
| 'autopilot',0,"nice --19 $SERVICES_PATH/ardupilot_manager/main.py" | ||
| 'cable_guy',0,"$SERVICES_PATH/cable_guy/main.py" | ||
| 'video',0,"nice --19 mavlink-camera-manager --default-settings BlueROVUDP --mavlink tcpout:127.0.0.1:5777 --mavlink-system-id $MAV_SYSTEM_ID --gst-feature-rank omxh264enc=0,v4l2h264enc=250,x264enc=260 --log-path /var/logs/blueos/services/mavlink-camera-manager --verbose" | ||
| 'video',0,"nice --19 mavlink-camera-manager --default-settings BlueROVUDP --mavlink tcpout:127.0.0.1:5777 --mavlink-system-id $MAV_SYSTEM_ID --gst-feature-rank omxh264enc=0,v4l2h264enc=250,x264enc=260 --log-path /var/logs/blueos/services/mavlink-camera-manager --stun-server stun://stun.l.google.com:19302 --verbose" |
Member
There was a problem hiding this comment.
@joaoantoniocardoso Will this affect cockpit usage in an environment where cockpit is used locally but internet is available ?
Member
There was a problem hiding this comment.
not if they use the filter, which is the default, right?
This was referenced Sep 23, 2024
ES-Alexander
added
docs-minimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviving #1842 as a fallback for remote control
This introduces a new optional
works_in_relative_pathsto the services metadata.These will use a relative path (under
/extensionv2/) to load the extension in the browser.This allows them to be used seamlessly behind a webserver with ssl.