creating "safe mode"#2888
Conversation
Williangalvani
force-pushed
the
safe
branch
5 times, most recently
from
5d69b46 to
0568e1f
Compare
Williangalvani
requested review from
joaoantoniocardoso,
joaomariolago,
patrickelectric and
rafaellehmkuhl
Williangalvani
force-pushed
the
safe
branch
from
0568e1f to
1caa7aa
Compare
| get is_safe() { | ||
| // We can potentially check for external things here | ||
| return !this.verhicle_armed | ||
| } | ||
|
|
There was a problem hiding this comment.
why is this not calling the backend instead?
There was a problem hiding this comment.
This will give us feedback at 1hz, I don't want yet another thing polling the backends at 1hz for no reason...
I can add to the comment "such as ardupilotManager's /safe endpoint"
There was a problem hiding this comment.
So why we have the safe endpoint in the backend ?
There was a problem hiding this comment.
hmm, so why was the backend endpoint added?
There was a problem hiding this comment.
for subsequent backend-based validations, such in ardupilot_manager.py and whatever else
| return await autopilot.available_boards(True) | ||
|
|
||
|
|
||
| @app.get("/safe") |
There was a problem hiding this comment.
Doesn't make more sense to move to "armed" ? Safe is to abstracted, and armed is a common term.
There was a problem hiding this comment.
@patrickelectric I think safe can abstract more than just arm, in case we want to check for other things..?
There was a problem hiding this comment.
any idea of other things that the backend of ardupilot_manager may know ?
It would be nice to have a comment about that.
There was a problem hiding this comment.
if there's a flashing operation in progress, for example, I'll add comments and/or more checking
There was a problem hiding this comment.
comment added, I'll leave the actual blocking checks to after @JoaoMario109 's refactor is done
…med (and possibly others in the future)
Williangalvani
force-pushed
the
safe
branch
from
1caa7aa to
db8c947
Compare
Williangalvani
requested review from
joaoantoniocardoso and
patrickelectric
ES-Alexander
added
docs-complete
4 participants
helps #2752