-
Notifications
You must be signed in to change notification settings - Fork 93
Remove timestamp from entrypoint log file #3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove timestamp from entrypoint log file #3279
Conversation
Reviewer's Guide by SourceryThis pull request removes the timestamp from the entrypoint log file name. The timestamp is added during log rotation, so it is redundant to have it in the entrypoint log file name. Updated class diagram for logsclassDiagram
class logs.py {
<<file>>
+get_new_log_path(service_name: str) Path
+init_logger(service_name: str) None
}
note for logs.py "Removes timestamp from entrypoint log file name"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @voorloopnul - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the timestamp was removed from the filename.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Timestamps are added in archives on rotation, the entrypoint having a timestamp creates an awkward situation where the log messages timestamp and log file name drift apart. ( currently entrypoint log name and rotation routine are not related )
97aa835
to
8a43557
Compare
Timestamps are added in archives on rotation, the entrypoint having a timestamp creates an awkward situation where the log messages timestamp and log file name drift apart.
( currently entrylog name and rotation routine are not related )
Summary by Sourcery
Enhancements: