-
Notifications
You must be signed in to change notification settings - Fork 92
Install: update blueos.service to start after docker #3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's GuideThe PR updates the BlueOS systemd unit to defer its startup until after Docker has initialized, shifting it out of the critical boot chain and improving overall boot parallelism. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Williangalvani - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@Williangalvani did you test it ? |
yes, this change on itself is not enough. dockerd.service is still waiting for network-online. |
Just to be clear, which issue ? |
this takes blueos out of blame and out of the critical chain, too: