core:services:kraken:manifest: Fix fetch latest version#3750
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Jan 29, 2026
Merged
core:services:kraken:manifest: Fix fetch latest version#3750patrickelectric merged 1 commit intobluerobotics:masterfrom
patrickelectric merged 1 commit intobluerobotics:masterfrom
Conversation
* Cover cases where ext version starts with 'v' prefix
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the logic for fetching the latest extension version so it can resolve versions stored with or without a leading 'v' prefix. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider normalizing version keys (e.g., stripping or adding the
vprefix) at a single point or via a helper method rather than checking both formats inline here, which would make future changes to version formatting easier. - The nested ternary and chained
orin the return statement slightly hurt readability; pullingversions[0]into a named variable and performing the two lookups on separate lines would make the intent clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider normalizing version keys (e.g., stripping or adding the `v` prefix) at a single point or via a helper method rather than checking both formats inline here, which would make future changes to version formatting easier.
- The nested ternary and chained `or` in the return statement slightly hurt readability; pulling `versions[0]` into a named variable and performing the two lookups on separate lines would make the intent clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
patrickelectric
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3694
Summary by Sourcery
Bug Fixes: