Skip to content

frontend: fix full_page extensions not showing up#3751

Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:fix_full_page
Feb 5, 2026
Merged

frontend: fix full_page extensions not showing up#3751
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:fix_full_page

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Jan 29, 2026

The issue can be seen by trying to open sonarview

I'm not sure if this breaks anything from #3714
It doesn't look like it, for me.

Summary by Sourcery

Bug Fixes:

  • Fix full-page iframe-based extensions not rendering due to incorrect container positioning.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the BrIframe container positioning so full-page iframe-based extensions render correctly by switching its v-sheet style from relative to absolute positioning.

File-Level Changes

Change Details Files
Fix iframe container positioning so full-page iframe extensions render correctly within the layout.
  • Change the v-sheet inline style in BrIframe from position: relative to position: absolute while keeping 100% width/height and overflow: hidden.
  • Rely on absolute positioning to allow iframe-based full-page extensions to cover the available area as intended.
core/frontend/src/components/utils/BrIframe.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Williangalvani Williangalvani marked this pull request as ready for review February 2, 2026 23:38
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Changing the iframe container from position: relative to position: absolute can have broad layout implications; consider scoping this with a dedicated class or only enabling it for full-page extensions to avoid unintentionally affecting other iframe usages.
  • It would help future readers to add a short comment in the template or component explaining why position: absolute is required here for full-page extensions, since it’s not obvious from the markup alone.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Changing the iframe container from `position: relative` to `position: absolute` can have broad layout implications; consider scoping this with a dedicated class or only enabling it for full-page extensions to avoid unintentionally affecting other iframe usages.
- It would help future readers to add a short comment in the template or component explaining why `position: absolute` is required here for full-page extensions, since it’s not obvious from the markup alone.

## Individual Comments

### Comment 1
<location> `core/frontend/src/components/utils/BrIframe.vue:5` </location>
<code_context>
     width="100%"
     height="100%"
-    style="overflow: hidden; position: relative;"
+    style="overflow: hidden; position: absolute;"
   >
     <spinning-logo
</code_context>

<issue_to_address>
**issue (bug_risk):** Switching to absolute positioning may break layout or stacking in some usages of BrIframe.

Because `position: absolute` removes the element from normal flow and depends on its parent’s positioning, this could change sizing, scrolling, or stacking in existing `BrIframe` usages. Please verify all `BrIframe` consumers have suitable parent containers and consider whether we need explicit positioning (`top/left`), `z-index`, or a wrapper to avoid layout regressions.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

width="100%"
height="100%"
style="overflow: hidden; position: relative;"
style="overflow: hidden; position: absolute;"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Switching to absolute positioning may break layout or stacking in some usages of BrIframe.

Because position: absolute removes the element from normal flow and depends on its parent’s positioning, this could change sizing, scrolling, or stacking in existing BrIframe usages. Please verify all BrIframe consumers have suitable parent containers and consider whether we need explicit positioning (top/left), z-index, or a wrapper to avoid layout regressions.

@patrickelectric
Copy link
Member

I have the same problem with sonarview with this PR, but cockpit works just fine..

@Williangalvani
Copy link
Member Author

I have the same problem with sonarview with this PR, but cockpit works just fine..

maybe your css was cached? I just re-tested and it worked fine on the PR...

@patrickelectric patrickelectric merged commit 222f7ae into bluerobotics:master Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments