KrakenManager: bump extension installation timeout to 10 minutes#3752
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Feb 2, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIncrease the HTTP request timeout for installing Kraken extensions from 2 minutes to 10 minutes to accommodate slower DockerHub responses. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the timeout value into a named constant or configuration setting so it can be adjusted without code changes and stays consistent across related calls.
- If installs can now hang for up to 10 minutes, consider whether there should be user-facing feedback or a cancel mechanism to avoid a poor UX when DockerHub is slow or unresponsive.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the timeout value into a named constant or configuration setting so it can be adjusted without code changes and stays consistent across related calls.
- If installs can now hang for up to 10 minutes, consider whether there should be user-facing feedback or a cancel mechanism to avoid a poor UX when DockerHub is slow or unresponsive.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
patrickelectric
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerhub seems slower than usual today, which is causing me to be unable to install both Madrona and "Oak D Visual Odometry" extensions
Summary by Sourcery
Enhancements: