Skip to content

KrakenManager: bump extension installation timeout to 10 minutes#3752

Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:long_install
Feb 2, 2026
Merged

KrakenManager: bump extension installation timeout to 10 minutes#3752
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:long_install

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Feb 2, 2026

Dockerhub seems slower than usual today, which is causing me to be unable to install both Madrona and "Oak D Visual Odometry" extensions

Summary by Sourcery

Enhancements:

  • Relax the Kraken extension installation timeout from 2 minutes to 10 minutes to improve reliability under slow network or registry conditions.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Increase the HTTP request timeout for installing Kraken extensions from 2 minutes to 10 minutes to accommodate slower DockerHub responses.

File-Level Changes

Change Details Files
Extend extension installation HTTP timeout from 120s to 600s.
  • Update the timeout value passed to the installExtension HTTP request configuration
  • Keep all other request parameters and behavior unchanged
core/frontend/src/components/kraken/KrakenManager.ts

Possibly linked issues

  • #(not specified): PR directly mitigates the issue by extending the extension installation timeout from 2 to 10 minutes.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the timeout value into a named constant or configuration setting so it can be adjusted without code changes and stays consistent across related calls.
  • If installs can now hang for up to 10 minutes, consider whether there should be user-facing feedback or a cancel mechanism to avoid a poor UX when DockerHub is slow or unresponsive.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the timeout value into a named constant or configuration setting so it can be adjusted without code changes and stays consistent across related calls.
- If installs can now hang for up to 10 minutes, consider whether there should be user-facing feedback or a cancel mechanism to avoid a poor UX when DockerHub is slow or unresponsive.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit 271747a into bluerobotics:master Feb 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments