Fix pardal crashing#3758
Merged
joaoantoniocardoso merged 3 commits intobluerobotics:masterfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMoves the speedtest-cli dependency from the helper service to the pardal service, updating project metadata and lockfile accordingly to fix pardal crashes due to missing dependency and remove an unused dependency from helper. Flow diagram for pardal startup before and after dependency fixflowchart TD
A[Start pardal service] --> B[Load pardal dependencies]
B --> C{speedtest_cli available?}
C -- No (before PR) --> D[ImportError in pardal]
D --> E[Service crash]
C -- Yes (after PR) --> F[Successful import of speedtest_cli]
F --> G[Pardal service runs normally]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
speedtest-cli==2.1.3is now directly depended on bypardal, consider centralizing this version pin (e.g., via a shared constraints mechanism) to avoid future version drift if other services also start using it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `speedtest-cli==2.1.3` is now directly depended on by `pardal`, consider centralizing this version pin (e.g., via a shared constraints mechanism) to avoid future version drift if other services also start using it.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
joaoantoniocardoso
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: #3729
Summary by Sourcery
Enhancements: