Skip to content

Fix pardal crashing#3758

Merged
joaoantoniocardoso merged 3 commits intobluerobotics:masterfrom
patrickelectric:fix-pardal
Feb 4, 2026
Merged

Fix pardal crashing#3758
joaoantoniocardoso merged 3 commits intobluerobotics:masterfrom
patrickelectric:fix-pardal

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Feb 4, 2026

From: #3729

Summary by Sourcery

Enhancements:

  • Move the speedtest-cli dependency from the helper service to the pardal service to align dependencies with actual usage.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Moves the speedtest-cli dependency from the helper service to the pardal service, updating project metadata and lockfile accordingly to fix pardal crashes due to missing dependency and remove an unused dependency from helper.

Flow diagram for pardal startup before and after dependency fix

flowchart TD
    A[Start pardal service] --> B[Load pardal dependencies]
    B --> C{speedtest_cli available?}

    C -- No (before PR) --> D[ImportError in pardal]
    D --> E[Service crash]

    C -- Yes (after PR) --> F[Successful import of speedtest_cli]
    F --> G[Pardal service runs normally]
Loading

File-Level Changes

Change Details Files
Reassign speedtest-cli dependency from helper service to pardal service.
  • Remove speedtest-cli from helper service runtime dependencies.
  • Add speedtest-cli to pardal service runtime dependencies.
  • Regenerate/update uv.lock to reflect the new dependency graph.
core/services/helper/pyproject.toml
core/services/pardal/pyproject.toml
core/uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since speedtest-cli==2.1.3 is now directly depended on by pardal, consider centralizing this version pin (e.g., via a shared constraints mechanism) to avoid future version drift if other services also start using it.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `speedtest-cli==2.1.3` is now directly depended on by `pardal`, consider centralizing this version pin (e.g., via a shared constraints mechanism) to avoid future version drift if other services also start using it.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaoantoniocardoso joaoantoniocardoso merged commit 8a82b86 into bluerobotics:master Feb 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments