Helper: fix pydantic v2 migration

[Williangalvani]

fix #3754

Summary by Sourcery

Update helper service metadata handling for compatibility with Pydantic v2.

Bug Fixes:

• Ensure optional fields in ServiceMetadata have explicit default values compatible with Pydantic v2.
• Replace deprecated parse_obj usage with model_validate when parsing service metadata responses.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates helper service metadata handling to be compatible with Pydantic v2 by adjusting optional field declarations and the model validation API.

Class diagram for updated ServiceMetadata Pydantic v2 model

classDiagram
    class BaseModel

    class ServiceMetadata {
        +str name
        +str company
        +str version
        +str webpage
        +Optional~str~ route
        +Optional~bool~ new_page
        +Optional~str~ extra_query
        +Optional~bool~ avoid_iframes
        +str api
        +Optional~str~ sanitized_name
        +Optional~bool~ works_in_relative_paths
        +Optional~Dict~str,str~~ extras
    }

    class ServiceInfo {
        +ServiceMetadata metadata
    }

    ServiceMetadata --|> BaseModel
    ServiceInfo --> ServiceMetadata

Loading

File-Level Changes

Change	Details	Files
Align ServiceMetadata model field definitions with Pydantic v2 optional/nullable semantics.	Import Field from pydantic for explicit default handling. Change Optional fields in ServiceMetadata to use Field(default=None) so they remain truly optional/nullable under Pydantic v2.	core/services/helper/main.py
Migrate ServiceMetadata JSON parsing to the Pydantic v2 validation API.	Replace deprecated parse_obj usage with model_validate when constructing ServiceMetadata from a response JSON dict in detect_service.	core/services/helper/main.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#3754	Fix Helper service metadata validation so that extension metadata JSON from services is successfully parsed without errors.	✅
#3754	Update Helper’s Pydantic usage to be compatible with Pydantic v2 for the ServiceMetadata model (including handling of optional fields and validation entry point).	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In detect_service, you can narrow the broad except Exception around ServiceMetadata.model_validate to pydantic.ValidationError (and possibly TypeError) so unexpected errors don’t get silently swallowed as metadata-parse issues.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `detect_service`, you can narrow the broad `except Exception` around `ServiceMetadata.model_validate` to `pydantic.ValidationError` (and possibly `TypeError`) so unexpected errors don’t get silently swallowed as metadata-parse issues.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}