Conversation
bc86de2 to
07b912b
Compare
e1d4e3c to
cb52d94
Compare
.github/workflows/publish-lib.yml
Outdated
| { | ||
| echo '{ | ||
| "name": "@bluerobotics/cockpit-api", | ||
| "version": "'${{ github.ref_name }}'", |
There was a problem hiding this comment.
I think we should not use the cockpit version here. thoughts?
There was a problem hiding this comment.
We shouldn't. Cockpit has new releases every week, while the API will probably be updated every few months.
cb52d94 to
13312b8
Compare
13312b8 to
4d6333e
Compare
|
This is presumably out of scope for this PR, but would this Cockpit API be the basis for supporting widgets registering their own Actions (per #609) in future? :-) |
4d6333e to
d714e58
Compare
Yes, the idea is to put their metadata in the same json. |
d714e58 to
b86d1cb
Compare
And to allow doing it programatically as we extend the API |
505a55a to
6c17b99
Compare
src/libs/actions/data-lake.ts
Outdated
| if (typeof data !== 'string' && typeof data !== 'number') return | ||
|
|
||
| if (dataLakeVariableInfo[id] === undefined) { | ||
| createDataLakeVariable(new DataLakeVariable(id, id, typeof data === 'string' ? 'string' : 'number')) |
There was a problem hiding this comment.
Should we keep this? I feel like it creates an incentive for people not to explicitly register their variables.
With the idea of also adding unit information to the variables, this will become more and more of a problem.
There was a problem hiding this comment.
I can make it happen only in ardupilot.ts for the mavlink data. I assume we don't want to register all mavlink data manually
There was a problem hiding this comment.
Agree, but in this case, to enforce the interface and so we can improve it in the future without having to change a lot of places in the code, I think it would be better to put this "type inferring" in the variable registration and register explicitly in the ardupilot file, even if without the type. It would just be this if clause, but in the ardupilot file instead of the data-lake itself. What do you think?
6c17b99 to
06fe122
Compare
No description provided.