Fix drifting in the joystick triggers#2399
Merged
rafaellehmkuhl merged 2 commits intobluerobotics:masterfrom Feb 13, 2026
Merged
Fix drifting in the joystick triggers#2399rafaellehmkuhl merged 2 commits intobluerobotics:masterfrom
rafaellehmkuhl merged 2 commits intobluerobotics:masterfrom
Conversation
ea1cb7b to
680af28
Compare
We need the forked version with the fixes to the initial joystick calibration sooner than we can expect for the upstream to be updated. This change should be reverted once the change is accepted upstream.
680af28 to
d716adc
Compare
Member
Author
|
@ES-Alexander @ArturoManzoli I need you guys help testing this one to make sure its fixed indeed. I've included instructions in the PR. Arturo if you could test it on both Linux and Windows that would be great (this way we make sure my build is working correctly for all versions). I'm putting this one in the fast-track as its a must for the RadCam release. |
ES-Alexander
approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Was painful to test, but confirmed working properly - nice work!
For future reference (from some internal discussion / debugging):
- Built binaries without defined versions are not re-installed/built with
yarn install/yarn dev:electronyarn upgrade sdlcan directly get the changed SDL binaryyarn install --forcecan more generally ensure all the packages are using their specified version
- To run a downloaded app from a PR artifact, the macOS gatekeeper needs to be disabled with
xattr -d com.apple.quarantine /Applications/Cockpit.app(or whatever application path you're using)
ArturoManzoli
approved these changes
Feb 13, 2026
Contributor
ArturoManzoli
left a comment
There was a problem hiding this comment.
All tested and working very well.
Tested on windows and linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem of drifting trigger inputs (non-zero values on the joystick triggers when not pressed).
To accomplish that it uses an updated version of
node-sdlwhich allow for the initial joystick/controller calibration to be bypassed, and adapts to the new range and behavior.This patch needs this change to be accepted onAs the upstream update is taking longer than we are able to wait, I've built it in my fork and pointed our project to use the forked build.node-sdl, and a consequently update of the lib version on our side.How to test it
Fix #2355