Improve video recording management#655
Conversation
b15501d to
2635a24
Compare
|
@joaoantoniocardoso @patrickelectric open for review. |
There was a problem hiding this comment.
Not critical, but confusing at least:
Because the widget shares a global state, and the source selection only happens when the user clicks the record/stop button, the user can't select a different source when there is a recording happening for the first source of the list of streams available, requiring the user to stop the recording before configuring the latter added widget:
cannot_change_recording_source_because_widgets_share_global_state.mp4
note that it is also impossible to record two videos from the same source (let's say, a quick clip and the entire dive)
Nice catch. |
2635a24 to
a496ffe
Compare
|
@joaoantoniocardoso fixed. |
Put the video store in charge of managing the video recordings, so recording information gets stored with the stream data. There are two main benefits on this:
Fix #624
Fix #633
To be merged after #654.