Open
Conversation
patrickelectric
requested changes
Sep 21, 2019
Member
There was a problem hiding this comment.
Hi Nick! Thanks for the PR.
Some points:
- The first commit is a bit generic, it will help to add at least a
(simple example)in the end. - The commits e570a23 and 7207b03 should be squashed since they are changing the same file for the same thing, there is no big reason to have two commits.
Commentsis a really generic commit title without body, and it appears that you are fixing what you did in d59069f, this should be squashed to avoid unnecessary commits.- Also, it appears that your code is failing to build, you can check that in travis:
ping1d-advanced:90:29: error: 'class Ping1D' has no member named 'gain_index'
Serial.println(ping.gain_index());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a little confusing to get this library working for hardware serial, now you can just use the compiler flag.
If this looks good, I'll update the docs to match.