Added Surveyor240, Omniscan500, and Sounder S500 packet definitions #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@BradG13531 I would recommend activating the actions in your fork to check if the PR is valid without waiting for me to activate the actions here, since is your first contribution. |
Member
|
We just fixed the CI to merge your PR, can you rebase over master ? |
…ice to definitions in generate-markdown.py
BradG13531
force-pushed
the
feature/surveyor-omniscan-s500
branch
from
896e3f5 to
e304a8b
Compare
patrickelectric
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Surveyor, Omniscan, and Sounder ping protocol packets by creating json files in the src/definitions directory. Also added these files to generate-markdown.py.