Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Display bucket name in log statement when downloading definition - #118

Open
Jean-Baptiste Le Duigou (jbleduigou) wants to merge 3 commits into
bluesentry:masterfrom
jbleduigou:master
Open

Display bucket name in log statement when downloading definition#118
Jean-Baptiste Le Duigou (jbleduigou) wants to merge 3 commits into
bluesentry:masterfrom
jbleduigou:master

Conversation

@jbleduigou

Copy link
Copy Markdown

Hi,

When using the tool I was confused by the following log message:

Downloading definition file /tmp/clamav_defs/main.cvd from s3://clamav_defs/main.cvd

At first I thought the definition was being downloaded from a bucket that was not mine.
This PR is about including the bucket name in that log message.

Signed-off-by: Jean-Baptiste Le Duigou jb.leduigou@gmail.com

Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
@CLAassistant

CLAassistant commented Mar 29, 2020

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jdepp
❌ jbleduigou
You have signed the CLA already but the status is still pending? Let us recheck it.

@jdepp

Copy link
Copy Markdown
Contributor

Hey Jean-Baptiste Le Duigou (@jbleduigou), thanks for the PR and good idea. It looks like the pre_commit_test is failing in Circle (it fails running black). Could you take a look?

@jbleduigou

Copy link
Copy Markdown
Author

Hi Jeremy Deppen (@jdepp), thanks for the review!
This looks like a formatting issue.
I will look into it.

Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou

Copy link
Copy Markdown
Author

Hi Jeremy Deppen (@jdepp), I have properly formatted the code.
Could you please review again this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants