This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Display bucket name in log statement when downloading definition - #118
Open
Jean-Baptiste Le Duigou (jbleduigou) wants to merge 3 commits into
Open
Display bucket name in log statement when downloading definition#118Jean-Baptiste Le Duigou (jbleduigou) wants to merge 3 commits into
Jean-Baptiste Le Duigou (jbleduigou) wants to merge 3 commits into
Conversation
Signed-off-by: Jean-Baptiste Le Duigou <jb.leduigou@gmail.com>
|
|
Jeremy Deppen (jdepp)
previously approved these changes
May 3, 2021
Contributor
|
Hey Jean-Baptiste Le Duigou (@jbleduigou), thanks for the PR and good idea. It looks like the |
Author
|
Hi Jeremy Deppen (@jdepp), thanks for the review! |
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
Jean-Baptiste Le Duigou (jbleduigou)
requested a review
from Jeremy Deppen (jdepp)
May 3, 2021 19:11
Author
|
Hi Jeremy Deppen (@jdepp), I have properly formatted the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When using the tool I was confused by the following log message:
At first I thought the definition was being downloaded from a bucket that was not mine.
This PR is about including the bucket name in that log message.
Signed-off-by: Jean-Baptiste Le Duigou jb.leduigou@gmail.com