apidir fallback resolution; bluepages tweaks; hepa apidir support #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation is to not have client request cancellation interrupt the resolution-and-cache process
brianolson
reviewed
Mar 13, 2025
| @@ -136,6 +141,14 @@ func (dir *APIDirectory) ResolveDIDRaw(ctx context.Context, did syntax.DID) (jso | |||
| if err != nil { | |||
| didResolution.WithLabelValues("apidir", "error").Inc() | |||
| didResolutionDuration.WithLabelValues("apidir", "error").Observe(time.Since(start).Seconds()) | |||
| if dir.Fallback != nil { | |||
There was a problem hiding this comment.
this and ResolveHandle should check what kind of error like Lookup* ?
maybe make a helper for 'is api service error' ?
| ctx := c.Request().Context() | ||
|
|
||
| hdl, err := syntax.ParseHandle(c.QueryParam("handle")) | ||
| ctx, cancel := context.WithTimeout(context.Background(), srv.requestTimeout) |
There was a problem hiding this comment.
this timeout around the whole action of the API handler is probably fine, but it makes me think that the timeout I'd really want is on the underlying client making outbound requests
brianolson
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.