✨ Fetch workspace data in batches and add advanced filtering #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace-bulk-fetch-repos-records
arcalinea
temporarily deployed
to
workspace-bulk-fetch-repos-records - ozone-staging PR #206
Render
Destroyed
foysalit
changed the title
foysalit
commented
Oct 4, 2024
| @@ -106,7 +106,7 @@ export const ModerationLabel = ({ | |||
| }) | |||
|
|
|||
| return ( | |||
| <Popover className="relative"> | |||
| <Popover className="relative z-20"> | |||
There was a problem hiding this comment.
this known z-index value helps us overlap other content on labels.
foysalit
commented
Oct 4, 2024
| }: { | ||
| listData: WorkspaceListData | undefined | ||
| }) => { | ||
| const [filters, setFilters] = useState({ |
There was a problem hiding this comment.
this can be cleaned up a bit bit it's not bad for a very isolated component.
devinivy
reviewed
Oct 4, 2024
| const handleRemoveSelected = () => { | ||
| const selectedItems = Array.from( | ||
| formRef.current?.querySelectorAll<HTMLInputElement>( | ||
| 'input[type="checkbox"][name="workspaceItem"]:checked', | ||
| ) || [], | ||
| ).map((checkbox) => checkbox.value) | ||
| removeItemsMutation.mutate(selectedItems) | ||
| removeItemsMutation.mutate(selectedItems as string[]) |
There was a problem hiding this comment.
Are the checkbox values always strings, never e.g. undefined?
There was a problem hiding this comment.
yep, these checkboxes always carry the value of the did/uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bluesky-social/atproto#2836
Use the newly available getRepos and getRecords endpoints to bulk fetch data for workspace items. This also allows us to provide additional context to workspace items without expanding into full view mode per item.
This PR also adds a way to filter items from the workspace based on a combination of options among accounts and other content type which allows mods to select/unselect items from workspace in batches.