Improve UX for removed embedded content #432
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcwill70
commented
Jan 20, 2026
| return thread | ||
| } catch (err) { | ||
| if (err instanceof GetPostThread.NotFoundError) { | ||
| return undefined |
Contributor
Author
There was a problem hiding this comment.
@foysalit The more robust way to catch the post not found error is probably to not return undefined here. However, I assumed that this is here for a reason so I added the conditional down below
If the post isn't found, the rest of the page will still render and only the RecordView component will be hidden. I'm not sure if this behavior is important or not but it minimizes behavioral changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly display a not found error if the record is not found