Use system libvips instead of pre-built one.#167
Open
mounirlamouri wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi! How would you feel about contributing this solution to https://github.com/bluesky-social/deploy-recipes instead? That way, we aren't adding a compile dependency to the official install script, but we can still document and support it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs
vips-devto the image sosharpcan use it. The change also installs a few dependencies requires forsharpto build the C++ files required.The version of
alpinewas upgraded from 18 to 19 because the minimumlibvipsrequired bysharpwasn't satisfied by alpine-18.Finally, in addition to copying
/apps, we are now also copying/liband/usr/libbecauselibvipsand some other dependencies are now needed. An alternative would be to list all the files needed but it would be tedious to maintain.This change improves portability and security as
pdsis no longer depending on code built by a library but instead depends on thealpinepackage. An immediate benefit is that thealpinepackage doesn't use SSE4.2 instructions, allowingpdsto run on older CPU like some Intel Atom processors.Fixes #158