Remove PDS_BLOB_UPLOAD_LIMIT from auto-generated env file#229
Open
ledlamp wants to merge 1 commit into
Open
Conversation
Please change the default blobUploadLimit in @atproto/pds instead Reverts 07299a2
Contributor
|
I kind of think there should still be some upload limit here, to prevent trivial abuse by users (who are probably invite-gated and somewhat trusted by PDS operator, but not always). Maybe 512 or 1024 MByte? |
Contributor
Author
|
No bruh, PDS has upload limit already. The environment variable is for overriding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please change the default blobUploadLimit in @atproto/pds instead: bluesky-social/atproto#3120
Bluesky has increased the limit again, and people are going to encounter issues yet again because their existing env files set the limit to 50MiB and it's not auto-updated like the PDS is.