Skip to content

improve pdsadmin invite based commands#301

Open
jaspermayone wants to merge 4 commits into
bluesky-social:mainfrom
jaspermayone-forks:feat/improvements-to-invite-create
Open

improve pdsadmin invite based commands#301
jaspermayone wants to merge 4 commits into
bluesky-social:mainfrom
jaspermayone-forks:feat/improvements-to-invite-create

Conversation

@jaspermayone

Copy link
Copy Markdown

I was trying to do this and it was frustrating me, so i've made a pr to improve things.

Copilot AI review requested due to automatic review settings December 27, 2025 20:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates invite code management into a new unified invite.sh script with enhanced functionality, replacing the basic create-invite-code.sh command. The new script provides both creation and listing capabilities with filtering options.

  • Adds pdsadmin invite command with list and create subcommands
  • Replaces deprecated create-invite-code command with improved invite create
  • Adds filtering options for listing invite codes (used, disabled, free)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
pdsadmin/invite.sh New comprehensive invite code management script with list and create subcommands, including filtering capabilities
pdsadmin/help.sh Updated help documentation to include new invite command and mark create-invite-code as removed
pdsadmin/create-invite-code.sh Removed old single-purpose invite code creation script
README.md Updated documentation to reference new pdsadmin invite create command instead of deprecated create-invite-code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pdsadmin/invite.sh Outdated
Comment thread pdsadmin/invite.sh
Comment thread pdsadmin/invite.sh Outdated
Comment thread pdsadmin/invite.sh
Comment thread pdsadmin/invite.sh
@axfelix

axfelix commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

This looks OK! However, these shell scripts aren't as actively maintained as https://github.com/bluesky-social/goat will be moving forward, and I'd like to at least keep them backwards compatible if we are considering any syntax changes. I can't promise we can merge this, but we're definitely likelier to merge it if it retains the old syntax as a backup.

@jaspermayone

Copy link
Copy Markdown
Author

Will update to add backwards compatibility!

@jaspermayone

Copy link
Copy Markdown
Author

@axfelix the bsky offical hosting guide should prob be updated to have people use goat if thats the better maintained thing going forward

@axfelix

axfelix commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Definitely, and we're in the middle of a big docs refresh you can see at bluesky-social/atproto-website#483 which should help with this!

Which guide did you follow, so I know if there's anything else unclear out there?

@jaspermayone

Copy link
Copy Markdown
Author

https://github.com/bluesky-social/pds#creating-an-account-using-an-invite-code

this was what lead me to using the old command!

@jaspermayone

Copy link
Copy Markdown
Author

updates look super cool! very exited!

@jaspermayone

Copy link
Copy Markdown
Author

@axfelix let me know if I can do anything to help in anyway! I love atproto!

@jaspermayone

Copy link
Copy Markdown
Author

This is good for re-review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants