Skip to content

Update SVGO#11083

Open
mozzius wants to merge 1 commit into
mainfrom
samuel/svgo
Open

Update SVGO#11083
mozzius wants to merge 1 commit into
mainfrom
samuel/svgo

Conversation

@mozzius

@mozzius mozzius commented Jul 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@claude

claude Bot commented Jul 7, 2026

Copy link
Copy Markdown

Claude finished @mozzius's task in 1m 4s —— View job


Review: Update SVGO

  • Read review guidance (.github/claude-review-prompt.md)
  • Analyze SVGO version bump + regenerated SVGs
  • Check for visual regressions in re-optimized icons
  • Post review

This PR looks fine. No blocking or non-blocking findings.

The change bumps svgo from ^3.3.2 to ^4.0.1 (dev dependency, used only by the icons:optimize script) and re-runs it over the icon assets. Every SVG diff is identical except that hex color literals are now lowercased (e.g. #006AFF#006aff, #080B12#080b12). This is a new default in SVGO 4's convertColors plugin.

What I checked:

  • All 11 SVG diffs are pure hex-case changes — no path data, viewBox, fill-rule, gradient stops, or structural attributes were altered. Hex colors are case-insensitive per the SVG/CSS spec, so there is no visual difference on iOS, Android, or Web.
  • Confirmed the uppercase hex values still present elsewhere in the codebase (app.config.js, src/alf/tokens.ts, src/view/icons/Logo.tsx, WelcomeModal.tsx, etc.) are standalone hardcoded JS/TS constants, not derived from or string-matched against these SVG asset contents — so lowercasing the assets can't desync anything.
  • These icons are bundled as assets; nothing does a case-sensitive comparison on the file bytes.

Non-blocking observation (optional, not a defect): SVGO 4 is a major version with plugin default changes beyond color casing. The diff here is limited to color case, which suggests the icons were already well-optimized, but it's worth a quick visual sanity-check of a couple of icons in-app since the tooling changed — purely as due diligence, not because I see a problem.
· samuel/svgo

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
Old size New size Diff
8.53 MB 8.53 MB 0 B (0.00%)

@estrattonbailey

Copy link
Copy Markdown
Member

Do we even need this? Forgot it was here tbh. The hardest part of exporting icons is collapsing everything into a single path. The minification is helpful, but using https://jakearchibald.github.io/svgomg/ is actually good for previewing too.

mozzius commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

I prefer it being in the repo because it standardizes the changes it applies. svgomg just uses svgo under the hood, so you can just dump svgs straight from figma into the assets folder and it will process it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants