Skip to content

Truncate handles in collapsed profile headers - #11577

Open
mozzius wants to merge 1 commit into
mainfrom
samuel/app-2791-truncate-collapsed-profile-handle
Open

Truncate handles in collapsed profile headers#11577
mozzius wants to merge 1 commit into
mainfrom
samuel/app-2791-truncate-collapsed-profile-handle

Conversation

@mozzius

@mozzius mozzius commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • truncate handles in collapsed profile headers to a single line
  • prevent long handles from increasing the collapsed header height

Closes APP-2791

Test plan

  • Open a profile with a long handle and scroll until the header collapses.
  • Confirm the handle truncates with an ellipsis and remains on one line.

@linear-code

linear-code Bot commented Aug 27, 2026

Copy link
Copy Markdown

APP-2791

@claude

claude Bot commented Aug 27, 2026

Copy link
Copy Markdown

Claude finished @mozzius's task in 41s —— View job


PR Review: Truncate handles in collapsed profile headers

  • Read repo conventions and review guidance
  • Reviewed the diff and all Layout.Header.SubtitleText call sites

Verdict

Looks good. The one-line change (numberOfLines={2}1 in SubtitleText, src/components/Layout/Header/index.tsx:222) does what the description says and keeps the collapsed header at a fixed height for long handles.

What I checked

SubtitleText is a shared component, so I traced every caller to make sure dropping the second line doesn't regress anything else:

  • Profile header (src/screens/Profile/Header/index.tsx:191) — the target case; renders sanitizeHandle(profile.handle), which is the long-string scenario this fixes. ✅
  • Post listsPostRepostedBy, PostQuotes, PostLikedBy render short Plural counts ("# reposts", etc.).
  • Profile listsProfileFollows, ProfileFollowers render "# following"/"# followers" counts.
  • Hashtag (src/screens/Hashtag.tsx) — count subtitle.

All non-profile callers pass short count strings that never reached a second line anyway, so the change is effectively a no-op for them and only affects the long-handle case it targets. ModuleHeader.SubtitleText (Search/Explore) is a separate component and untouched.

No i18n, platform, or moderation concerns. Nothing blocking.
· samuel/app-2791-truncate-collapsed-profile-handle

@github-actions

Copy link
Copy Markdown
Contributor
Old size New size Diff
8.04 MB 8.04 MB 0 B (0.00%)

@github-actions

Copy link
Copy Markdown
Contributor

The OTA deployment for this PR was successful! You may now apply it by either scanning the QR code or opening the deep link below in your browser:

QR code for the PR OTA deployment

bluesky://intent/apply-ota?channel=pull-request-11577&releaseVersion=1.132.0&iosBuildNumber=2049&androidBuildNumber=1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants