You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: Truncate handles in collapsed profile headers
Read repo conventions and review guidance
Reviewed the diff and all Layout.Header.SubtitleText call sites
Verdict
Looks good. The one-line change (numberOfLines={2} → 1 in SubtitleText, src/components/Layout/Header/index.tsx:222) does what the description says and keeps the collapsed header at a fixed height for long handles.
What I checked
SubtitleText is a shared component, so I traced every caller to make sure dropping the second line doesn't regress anything else:
Profile header (src/screens/Profile/Header/index.tsx:191) — the target case; renders sanitizeHandle(profile.handle), which is the long-string scenario this fixes. ✅
Post lists — PostRepostedBy, PostQuotes, PostLikedBy render short Plural counts ("# reposts", etc.).
All non-profile callers pass short count strings that never reached a second line anyway, so the change is effectively a no-op for them and only affects the long-handle case it targets. ModuleHeader.SubtitleText (Search/Explore) is a separate component and untouched.
No i18n, platform, or moderation concerns. Nothing blocking.
· samuel/app-2791-truncate-collapsed-profile-handle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes APP-2791
Test plan